eth/gasprice/gasprice.go (1)

198-205: LGTM! Well-documented change with clear rationale.

The comments effectively explain why increasing the minimum tip to 100 wei is necessary:

1. To avoid txpool transaction replacement issues
2. To handle integer arithmetic rounding
3. While maintaining negligible cost impact

Consider adding a code comment with an example of the rounding issue, e.g.:

 //   - txpool commonly prevents replacing transactions with the same tip cap.
 //   - A 1 wei tip may fail to increase (e.g., 1.1x rounds down to 1 wei) due to integer arithmetic.
+//     Example: 1 wei * 1.1 = 1.1 wei, which rounds down to 1 wei
 // 2. Negligible cost:

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Search for potential hardcoded minimum tip values or tip-related tests
rg -A 2 -B 2 "tip.*wei|wei.*tip" --type go

# Search for any other gas price oracle tests that might need updates
fd -e go -x grep -l "SuggestTipCap"

#!/bin/bash
# Let's examine the implementation and usage of SuggestTipCap across files
ast-grep --pattern 'SuggestTipCap($$$)'

# Let's also check for any direct references to tip values
rg -A 3 -B 3 '(minimum|min).*tip' --type go

eth/gasprice/gasprice.go (4)

43-48: Enhance code comments for clarity and consistency

The added comments explaining the reasons for setting DefaultGasTip to 100 wei are informative. However, consider reformatting them for better readability and consistency with Go's commenting style.

Apply this diff to improve the comments:

 // DefaultGasTip is set to 100 wei instead of 1 wei for the following reasons:
-// 1. It prevents issues with very low tip values (e.g., 1 wei):
-//    - Transaction pools commonly prevent replacing transactions with the same tip cap.
-//    - Extremely low tips like 1 wei may fail to increase due to rounding in integer arithmetic of SDK implementations (e.g. 1 wei * 1.5 = 1 wei).
-// 2. The cost of gas tip 100 wei is negligible compared to base fee normally.
+//
+// 1. Prevents issues with very low tip values (e.g., 1 wei):
+//    - Transaction pools may prevent replacing transactions with the same tip cap.
+//    - Extremely low tips like 1 wei may not increase due to rounding errors in SDK implementations (e.g., 1 wei * 1.5 = 1 wei).
+// 2. The cost of a gas tip of 100 wei is negligible compared to the base fee.
 //

---

61-61: Add documentation for the new DefaultGasTip field

The DefaultGasTip field in the Config struct lacks a comment explaining its purpose. Adding a comment will improve code readability and maintainability.

Add a comment above the DefaultGasTip field:

+    // DefaultGasTip is the default minimum tip cap to use after the Curie upgrade (EIP-1559).
     DefaultGasTip      *big.Int `toml:",omitempty"` // Default minimum tip cap to use after Curie (EIP 1559).

---

92-92: Initialize defaultGasTip in the Oracle struct properly

The Oracle struct now includes the defaultGasTip field, but it lacks a comment explaining its purpose. Also, ensure consistency with other field comments.

Add a comment for the defaultGasTip field:

     congestedThreshold                int      // Number of pending transactions to consider the network congested and suggest a minimum tip cap.
     defaultBasePrice                  *big.Int // Base price to set when CongestedThreshold is reached before Curie (EIP-1559).
+    defaultGasTip                     *big.Int // Default minimum tip cap to use after Curie (EIP-1559).
     historyCache                      *lru.Cache

---

211-214: Clarify the logic in SuggestTipCap method

The comments and logic in the SuggestTipCap method could be improved for clarity. Specifically, mention that the default gas tip is used after the Curie upgrade, and the default base price is used before Curie.

Modify the comments for better understanding:

     if pendingTxCount < oracle.congestedThreshold {
         // Determine the suggested gas price based on the network configuration:
-        // - Before Curie (EIP-1559): total gas price = base fee + tip cap.
-        // - After Curie (EIP-1559): use the default tip cap.
+        // - Before Curie (EIP-1559): use the default base price.
+        // - After Curie (EIP-1559): use the default gas tip.
         price := oracle.defaultGasTip

Additionally, ensure that the comments accurately reflect the code logic.

cmd/utils/flags.go (1)

744-747: Verify consistency of flag naming and usage descriptions

The new flag GpoDefaultGasTipFlag uses the name gpo.defaultgastip. For consistency with other flags, consider using hyphens instead of camel case in the flag name. Also, clarify the usage description.

Modify the flag definition:

 GpoDefaultGasTipFlag = cli.Int64Flag{
-    Name:  "gpo.defaultgastip",
+    Name:  "gpo.default-gas-tip",
-    Usage: "Default minimum tip cap (in wei) to be used after Curie fork (EIP-1559)",
+    Usage: "Default minimum tip cap (in wei) to use after the Curie upgrade (EIP-1559)",
 }

This change ensures consistency with other flags and improves readability.

Configuration used: CodeRabbit UI
Review profile: CHILL

eth/gasprice/gasprice.go (2)

92-92: Consider enhancing the field comment

While the field addition is correct, the comment could be more specific about when this tip is used.

-	defaultGasTip                     *big.Int // Default gas tip to suggest when the network is not congested.
+	defaultGasTip                     *big.Int // Default gas tip (in wei) to suggest when the network is not congested (pendingTxCount < congestedThreshold).

---

211-213: Consider clarifying the pre/post-Curie behavior in comments

While the logic is correct, the comment could be clearer about the behavioral differences.

-		// Before Curie (EIP-1559), we need to return the total suggested gas price. After Curie we return defaultGasTip wei as the tip cap,
-		// as the base fee is set separately or added manually for legacy transactions.
+		// Gas price behavior differs based on Curie (EIP-1559) activation:
+		// - Pre-Curie: Returns defaultBasePrice as the total gas price
+		// - Post-Curie: Returns defaultGasTip (100 wei) as the tip cap only, since base fee is handled separately

Configuration used: CodeRabbit UI
Review profile: CHILL

Configuration used: CodeRabbit UI
Review profile: CHILL

eth/gasprice/gasprice.go (1)

144-148: Minor: Improve consistency in log message

The validation logic is correct, but the log message could be more consistent by using the local variable instead of the constant.

-		log.Warn("Sanitizing invalid gasprice oracle default gas tip cap", "provided", params.DefaultGasTipCap, "updated", DefaultGasTipCap)
+		log.Warn("Sanitizing invalid gasprice oracle default gas tip cap", "provided", params.DefaultGasTipCap, "updated", defaultGasTipCap)

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Check for test coverage of the new gas tip behavior

# Look for related test files
fd -e go -e _test.go gasprice

# Check for test cases covering the new defaultGasTipCap
rg -A 5 "TestSuggest.*TipCap|TestNewOracle.*GasTip"

#!/bin/bash
# Check the implementation of the test cases to verify coverage
rg -B 5 -A 15 "TestSuggestTipCapCongestedThreshold" eth/gasprice/gasprice_test.go

#!/bin/bash
# Get the full test case implementations
rg -B 10 -A 30 "TestSuggestTipCapCongestedThreshold" eth/gasprice/gasprice_test.go